Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search functionality for ID, host, and description fields #2750

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

anldrms
Copy link
Contributor

@anldrms anldrms commented Feb 23, 2023

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

This PR adds search functionality for fields like ID, host, and description. Users can now search for specific entries in the dataset using keywords in these fields.

Related issues

fix/resolve #2729

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #2750 (d01e13e) into master (7c264b0) will decrease coverage by 2.28%.
The diff coverage is 25.00%.

❗ Current head d01e13e differs from pull request most recent head 34e6ecf. Consider uploading reports for the commit 34e6ecf to get more accurate results

@@            Coverage Diff             @@
##           master    #2750      +/-   ##
==========================================
- Coverage   76.42%   74.15%   -2.28%     
==========================================
  Files         139      201      +62     
  Lines        3759     7859    +4100     
  Branches      877      881       +4     
==========================================
+ Hits         2873     5828    +2955     
- Misses        886     1721     +835     
- Partials        0      310     +310     
Flag Coverage Δ
backend-e2e-test-ginkgo 65.08% <0.00%> (?)
backend-unit-test 49.89% <0.00%> (?)
frontend-e2e-test 76.45% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/internal/handler/route/route.go 78.11% <0.00%> (ø)
api/internal/handler/service/service.go 90.62% <0.00%> (ø)
api/internal/handler/upstream/upstream.go 84.52% <0.00%> (ø)
web/src/pages/Route/List.tsx 75.43% <ø> (ø)
web/src/pages/Service/List.tsx 94.87% <ø> (ø)
web/src/pages/Upstream/List.tsx 95.00% <ø> (ø)
web/src/pages/Route/service.ts 81.81% <100.00%> (ø)
web/src/pages/Service/service.ts 100.00% <100.00%> (ø)
web/src/pages/Upstream/service.ts 100.00% <100.00%> (ø)
api/internal/handler/label/label.go 86.20% <0.00%> (ø)
... and 61 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SkyeYoung
Copy link
Member

Please fix this?
image

@anldrms
Copy link
Contributor Author

anldrms commented Feb 28, 2023

Please fix this? image

Do you know what causes exactly happened?

Copy link
Contributor

@Baoyuantop Baoyuantop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Codes LGTM!
You will also need to provide E2E testing for this code, so feel free to ask questions if you have any.

@anldrms
Copy link
Contributor Author

anldrms commented Mar 1, 2023

@Baoyuantop could you review it again? I implement the e2e testings.

Copy link
Member

@SkyeYoung SkyeYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤔

@bzp2010 bzp2010 merged commit df0452e into apache:master Mar 9, 2023
@bzp2010
Copy link
Contributor

bzp2010 commented Mar 9, 2023

Nice job, thanks for your contribution!

Baoyuantop pushed a commit to Baoyuantop/apisix-dashboard that referenced this pull request Mar 22, 2023
Baoyuantop added a commit that referenced this pull request Mar 23, 2023
* chore: update the year in the  NOTICE (#2726)

fix: #2724

* fix plugins display in list of routes (#2704)

Co-authored-by: litesun <[email protected]>

* fix: plugin config page error (#2739)

* fix: plugin disable invalid in API /plugin?all=true (#2737)

* chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 in /web (#2730)

* fix: update URL of the online playground (#2760)

* chore: update dependency (#2752)

* chore: update dependency

---------

Co-authored-by: rongxin <[email protected]>

* fix: remove route name length limit (#2759)

* fix: change regex template to optional in proxy write (#2762)

* fix: ssl table expiration time display (#2763)

* feat: add search functionality for id, host, and description fields (#2750)

Co-authored-by: Anil Durmus <[email protected]>

* fix: disable global plugin invalid (#2757)

* feat: support ipv6 in upstream nodes (#2766)

* fix: upstream nodes metadata miss (#2773)

* fix: remove ssl check in redirect https (#2770)

---------

Co-authored-by: Shivam0500 <[email protected]>
Co-authored-by: incubator4 <[email protected]>
Co-authored-by: litesun <[email protected]>
Co-authored-by: Joanthan Chen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JunXu Chen <[email protected]>
Co-authored-by: Xin Rong <[email protected]>
Co-authored-by: rongxin <[email protected]>
Co-authored-by: Anil Baki Durmus <[email protected]>
Co-authored-by: Anil Durmus <[email protected]>
YXZhdHI pushed a commit to YXZhdHI/apisix-dashboard that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching routes by hosts - FR
5 participants